Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🧪 TESTS: Entirely remove AiidaTestCase #5372

Merged
merged 3 commits into from
Feb 22, 2022

Conversation

chrisjsewell
Copy link
Member

@chrisjsewell chrisjsewell commented Feb 22, 2022

bye bye 👋

@ltalirz
Copy link
Member

ltalirz commented Feb 22, 2022

Thanks a lot @chrisjsewell !

I don't have the time to go through all of the 85 modified files here; if there's something particular I should have a look at, let me know.

@chrisjsewell
Copy link
Member Author

Heya, erm not particularly; in #5330 I already ensured consistency between the AiidaTestCase and the aiida_profile_clean test fixture, then this PR just follows the conversion process I outlined in #4782

So, personally, I'm happy that everything here is fine, and obviously all the tests are still passing, which is the main thing.

@chrisjsewell
Copy link
Member Author

chrisjsewell commented Feb 22, 2022

Ok well @sphuber has swooped in and approved lol, @ltalirz are you happy for me to merge, or did you still want to look at anything?

@ltalirz
Copy link
Member

ltalirz commented Feb 22, 2022

All good, go ahead

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants