GroupParamType: store group if created
#5411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When `create_if_not_exist` is equal to `True`, the `GroupParamType` will create the group if it is not found when `convert` is called. The returned group however was not stored forcing the caller to store it themselves. When a client sets `create_if_not_exist` for a CLI command it will be extremely unlikely that they don't want the group to be stored.
sphuber
force-pushed
the
fix/5409/group-param-type-store
branch
from
e9f30b0
to
271232b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5409
When
create_if_not_existis equal toTrue, theGroupParamTypewillcreate the group if it is not found when
convertis called. Thereturned group however was not stored forcing the caller to store it
themselves. When a client sets
create_if_not_existfor a CLI commandit will be extremely unlikely that they don't want the group to be
stored.