Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ REFACTOR: Remove Entity.from_backend_entity from the public API #5447

Merged
merged 1 commit into from
Dec 14, 2022

Conversation

chrisjsewell
Copy link
Member

This should not be exposed on the public API, for e.g. Node (see #4976).
Instead, we move it to a pure function.

Note, you could rename to Entity._from_backend_entity, but this generates numerous pylint protected-access warnings

@sphuber sphuber force-pushed the orm-node-from_backend_entity branch 3 times, most recently from 99430d2 to 9d603b5 Compare December 14, 2022 09:01
Move it to a standalone function in `aiida.orm.entities`.
@sphuber sphuber self-requested a review December 14, 2022 09:11
Copy link
Contributor

@sphuber sphuber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @chrisjsewell . I have rebased the branch and addressed the merge conflicts. Good for me to merge

@chrisjsewell
Copy link
Member Author

@sphuber you know we are in a meeting right now 😉

@chrisjsewell
Copy link
Member Author

Good for me to merge

but yeh go for it

@sphuber sphuber merged commit 6608e0d into aiidateam:main Dec 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants