CLI: normalize use of colors #5547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Certain CLI commands used coloring in the output that was inconsistent with what users might expect based on other parts of the CLI and basic intuition. For example, red was sometimes used to highlight a purely informative piece of data or a header, but red is typically associated with errors. To normalize the use of colors, all uses of it use the `COLORS` mapping from the `aiida.cmdline.utils.echo` module and instead of naming the literal color, it designates the intended meaning.
|
This should address all the inconsistencies in the main code base @ltalirz . Essentially a few cases where red was used where it now uses the more suitable blue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5542
Certain CLI commands used coloring in the output that was inconsistent
with what users might expect based on other parts of the CLI and basic
intuition. For example, red was sometimes used to highlight a purely
informative piece of data or a header, but red is typically associated
with errors.
To normalize the use of colors, all uses of it use the
COLORSmappingfrom the
aiida.cmdline.utils.echomodule and instead of naming theliteral color, it designates the intended meaning.