Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CalcJob: allow wildcards in stash.source_list paths #5601

Merged
merged 2 commits into from
Jul 22, 2022
Merged

CalcJob: allow wildcards in stash.source_list paths #5601

merged 2 commits into from
Jul 22, 2022

Conversation

sphuber
Copy link
Contributor

@sphuber sphuber commented Jul 14, 2022 •
edited by yakutovicha
Loading

fixes #5600

@sphuber sphuber force-pushed the feature/5600/stashing-wildcards branch 4 times, most recently from ffe2140 to d183a78 Compare July 14, 2022 21:24
@sphuber sphuber force-pushed the feature/5600/stashing-wildcards branch from d183a78 to ee95303 Compare July 14, 2022 22:07
@sphuber
Copy link
Contributor Author

sphuber commented Jul 14, 2022

@yakutovicha think this should do the trick. Could you give this branch a go?

@yakutovicha
Copy link
Contributor

I will test it either later today or on Monday if that is fine.

@yakutovicha yakutovicha self-requested a review July 20, 2022 12:25
yakutovicha
yakutovicha previously approved these changes Jul 20, 2022
View reviewed changes
Copy link
Contributor

@yakutovicha yakutovicha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, and all works fine. Thanks a lot @sphuber!

@yakutovicha yakutovicha enabled auto-merge (squash) July 22, 2022 22:32
@yakutovicha yakutovicha self-requested a review July 22, 2022 22:32
@yakutovicha yakutovicha merged commit e141f97 into aiidateam:main Jul 22, 2022
@sphuber sphuber deleted the feature/5600/stashing-wildcards branch July 25, 2022 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yakutovicha yakutovicha yakutovicha approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Stashing does not accept wildcards.
2 participants
@sphuber @yakutovicha