-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: add section on basic performance benchmark #5635
Docs: add section on basic performance benchmark #5635
Conversation
529cad7
to
a1d3640
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks a lot @sphuber !
I've added a few comments on the docs (haven't yet looked at the code much; I assume that will be fine)
docs/source/howto/include/scripts/performance_benchmark_base.py
Outdated
Show resolved
Hide resolved
docs/source/howto/include/scripts/performance_benchmark_base.py
Outdated
Show resolved
Hide resolved
e9e9fd1
to
a4629f0
Compare
@ltalirz I have addressed the comments and added a section to topics on performance. Even though the latter isn't really part of the focus of this PR, I already added some text as to not have it completely empty. But maybe should not go down the rabbithole too much for this PR on that part. |
I added one further commit in #5723 If that seems fine, please cherry-pick it here and close that PR |
ff9f66c
to
f39d4b8
Compare
Thanks, all fine. I cherry-picked the commit here. Just corrected a mistake in the script that was probably added by accident and some minor corrections in the docs (broken label). |
Thanks for the fixes! I see I still introduced some remaining issues?
|
The section provides a basic script to benchmark the performance of an AiiDA installation by launching a number of `ArithmeticAddCalculation` jobs. The script by default automatically sets up the required `Code` and localhost `Computer`. All created nodes are automatically deleted from the database at the end. The documentation gives instructions on how to run the script and provides example output of a run on a typical work station including completion times for runs with variable number of daemon workers. This should give users an idea of the performance of their installation.
f39d4b8
to
12d3721
Compare
This was just an incorrect link (it is relative, but we moved it to another subfolder).
This was actually a nasty one. The error messages of Sphinx are often not very useful. The problem was the following
Apparently, you cannot have this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks a lot @sphuber !
docs/source/topics/performance.rst
Outdated
The performance of AiiDA depends on many factors: | ||
|
||
* the hardware that AiiDA is running on | ||
* the environment in which AiiDA is installed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what do you mean by that specifically?
until this section is fleshed out, you could also just leave it out
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had originally added this but already removed it when cherry-picking your commit, where you suggested to remove it. Think you were looking at an outdated diff.
What I mean with the environment is the runtime for AiiDA, i.e. is it installed with Conda, in virtual-env, or system wide, or maybe running in a container, etc. It is not quite clear if and how much of an impact it could have, but I thought it would be good to have the list complete. But now I think it is fine to just omit it for the time being.
The section provides a basic script to benchmark the performance of an AiiDA installation by launching a number of `ArithmeticAddCalculation` jobs. The script by default automatically sets up the required `Code` and localhost `Computer`. All created nodes are automatically deleted from the database at the end. The documentation gives instructions on how to run the script and provides example output of a run on a typical work station including completion times for runs with variable number of daemon workers. This should give users an idea of the performance of their installation. Cherry-pick: 07c1ba9
The section provides a basic script to benchmark the performance of an AiiDA installation by launching a number of
ArithmeticAddCalculation
jobs. The script by default automatically sets up the requiredCode
and localhostComputer
. All created nodes are automatically deleted from the database at the end.The documentation gives instructions on how to run the script and provides example output of a run on a typical work station including completion times for runs with variable number of daemon workers. This should give users an idea of the performance of their installation.