CLI: Make filename in verdi node repo cat optional for SinglefileData
#5747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ata` The `verdi node repo cat` requires the relative path of the file that is to be displayed. For a `SinglefileData`, however, there only is a single path. The `RELATIVE_PATH` argument is now made optional if the node is a `SinglefileData`, otherwise it will raise like it always did.
sphuber
force-pushed
the
feature/5746/verdi-node-repo-cat-singlefile
branch
from
c6200cf
to
d07cc81
Compare
unkcpz
reviewed
Nov 4, 2022
| if not isinstance(node, SinglefileData): | ||
| raise click.BadArgumentUsage('Missing argument \'RELATIVE_PATH\'.') | ||
|
|
||
| relative_path = node.filename |
There was a problem hiding this comment.
Can you remind me a bit what is the default filename if using the filelike for the SinglefileData?
There was a problem hiding this comment.
That is handled here
so it is set tofile.txt in that case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5746
The
verdi node repo catrequires the relative path of the file that is to be displayed. For aSinglefileData, however, there only is a single path. TheRELATIVE_PATHargument is now made optional if the node is aSinglefileData, otherwise it will raise like it always did.