Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixtures: Add support for Process inputs to submit_and_await #5780

Merged
merged 1 commit into from
Nov 18, 2022

Conversation

sphuber
Copy link
Contributor

@sphuber sphuber commented Nov 18, 2022

Currently the submit_and_await fixture did allow passing a Process class, but not to provide the inputs needed to instantiate it. The fixture now accepts kwargs which are used as the inputs in the case that submittable is a process class.

@sphuber sphuber force-pushed the fix/submit-and-await-support-kwargs branch from 268ff0a to 05fea26 Compare November 18, 2022 13:03
Currently the `submit_and_await` fixture did allow passing a `Process`
class, but not to provide the inputs needed to instantiate it. The
fixture now accepts `kwargs` which are used as the inputs in the case
that `submittable` is a process class.
@sphuber sphuber force-pushed the fix/submit-and-await-support-kwargs branch from 05fea26 to cda4223 Compare November 18, 2022 13:23
@sphuber sphuber requested a review from unkcpz November 18, 2022 13:33
Copy link
Member

@unkcpz unkcpz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks all good, thanks!

@sphuber sphuber merged commit 2f51a9f into aiidateam:main Nov 18, 2022
@sphuber sphuber deleted the fix/submit-and-await-support-kwargs branch November 18, 2022 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants