Process: Have inputs property always return AttributesFrozenDict
#6010
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sphuber
force-pushed
the
fix/process-inputs
branch
from
030353d
to
706e851
Compare
The `Process.inputs` property as implemented in `plumpy` has as a return type `AttributesFrozenDict | None`. This leads to a lot unnecessary complexities in the code having to deal with the potential `None`, where really this should never really occur. A lot of user code will never even check for `Process.inputs` returning `None`, such as in `WorkChain` implementations, and as a result type checkers will fail forcing a user to either unnecessarily complicate their code by explicitly checking for `None`, but will typically end up silencing the error. The `inputs` property is overridden here to return an empty `AttributesFrozenDict` in case the inputs are `None`, which allows to simplify the return type and get rid of any type errors in downstream code.
sphuber
force-pushed
the
fix/process-inputs
branch
from
706e851
to
b540599
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Process.inputsproperty as implemented inplumpyhas as a return typeAttributesFrozenDict | None. This leads to a lot unnecessary complexities in the code having to deal with the potentialNone, where really this should never really occur. A lot of user code will never even check forProcess.inputsreturningNone, such as inWorkChainimplementations, and as a result type checkers will fail forcing a user to either unnecessarily complicate their code by explicitly checking forNone, but will typically end up silencing the error.The
inputsproperty is overridden here to return an emptyAttributesFrozenDictin case the inputs areNone, which allows to simplify the return type and get rid of any type errors in downstream code.