Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trigger the DbLogHandler for exceptions in WorkChains run by daemon #908

Conversation

sphuber
Copy link
Contributor

@sphuber sphuber commented Nov 10, 2017

Exceptions that are encountered when ticking processes only got
logged to the daemon log but did not go through the logger of the
process itself and therefore the exception message was not in any
retrievable through the WorkCalculation node.
In the tick_workflow_engine of the daemon, when an exception occurs
in the ticking of the process, a log message is sent to the logger
of the process which should have the DbLogHandler configured, which
will cause the message to end up in the DbLog table. This message
will then be accessible through for example 'verdi work report'

Exceptions that are encountered when ticking processes only got
logged to the daemon log but did not go through the logger of the
process itself and therefore the exception message was not in any
retrievable through the WorkCalculation node.
In the tick_workflow_engine of the daemon, when an exception occurs
in the ticking of the process, a log message is sent to the logger
of the process which should have the DbLogHandler configured, which
will cause the message to end up in the DbLog table. This message
will then be accessible through for example 'verdi work report'
@sphuber sphuber added this to the v0.10.0 milestone Nov 10, 2017
Copy link
Member

@giovannipizzi giovannipizzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@giovannipizzi giovannipizzi merged commit cc9d06b into aiidateam:release_v0.10.0rc3 Nov 10, 2017
@sphuber sphuber deleted the fix_907_add_exception_to_workcalculation_report branch November 13, 2017 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants