Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependencies: put upper limit markupsafe<2.1 #326

Closed
wants to merge 1 commit into from

Conversation

unkcpz
Copy link
Member

@unkcpz unkcpz commented Mar 3, 2022

The latest release markupsafe==2.1 breaks jinja<3.0 and that in
turn breaks click.

The latest release `markupsafe==2.1` breaks `jinja<3.0` and that in
turn breaks `click`.
@codecov
Copy link

codecov bot commented Mar 3, 2022

Codecov Report

Merging #326 (7841462) into develop (a066be4) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #326   +/-   ##
========================================
  Coverage    92.93%   92.93%           
========================================
  Files           32       32           
  Lines         1373     1373           
========================================
  Hits          1276     1276           
  Misses          97       97           
Flag Coverage Δ
aiida 89.36% <ø> (ø)
mongo 79.16% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a066be4...7841462. Read the comment docs.

@CasperWA
Copy link
Collaborator

CasperWA commented Mar 3, 2022

Indeed. But this is not an issue of aiida-optimade but rather of aiida-core.
The failing workflows fail before they even touch anything aiida-optimade.
Only pip, setuptools, wheel, and aiida-core are installed before running verdi. Hence this really shouldn't be a fix implemented here but rather as a patch to AiiDA, which should then make all this work again.

@CasperWA
Copy link
Collaborator

CasperWA commented Mar 3, 2022

As a reference, this was also an issue in the upstream OPTIMADE Python tools (optimade) package, which has now been fixed and a patch version released. This is being updated in #325, and there the failing CI jobs are the same as here, essentially.

@unkcpz
Copy link
Member Author

unkcpz commented Mar 3, 2022

@CasperWA thanks. So if I understand correctly, this issue comes from the optimade[mongo]~=0.16.10? Since the issue only happened to aiida-core for [docs]. This will be fixed once that PR is merged?

@CasperWA
Copy link
Collaborator

CasperWA commented Mar 3, 2022

So if I understand correctly, this issue comes from the optimade[mongo]~=0.16.10?

No. See this run. And see the workflow here.
It's clear from the run that optimade is not installed. The only package directly installed are: pip, setuptools, wheel, and aiida-core - everything else are dependencies of those.
Then in the step "Load test data (AiiDA)" the jinja issue arises through calling verdi import.

Ergo it seems to be an issue with the latest release of AiiDA that needs to be fixed.
And it is already fixed in the master branch of AiiDA, but it has not yet been released, hence my comment here.

@CasperWA
Copy link
Collaborator

CasperWA commented Mar 8, 2022

Fixed in #329

@CasperWA CasperWA closed this Mar 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants