Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

👌 Refresh template plugin #88

Merged
merged 3 commits into from
Jan 18, 2022

Conversation

chrisjsewell
Copy link
Member

@chrisjsewell chrisjsewell commented Jan 18, 2022

  • Move to flit for PEP 621 compliant build (see also 🔧 Move to flit for PEP 621 compliant package build aiida-core#5312)
  • Remove setup.py, setup.json, MANIFEST.in, check_version.py, and .coveragerc
  • Set requires-python = ">=3.7"
  • Move from yapf to black for code formatting
  • Add isort and pyupgrade pre-commit hooks
  • Move documentation theme from sphinx-rtd-theme to furo
  • Add tox configuration (in pyproject.toml)

Note the setuptools reentry_register hook is no longer possible, although reentry is anyway removed in AiiDA v2 (and I never found this to actually work?).

- Move to flit for PEP 621 compliant build
- Remove setup.py, setup.json, and MANIFEST.in, check_version.py, .coveragerc
- Move from yapf to black for code formatting
- Add isort and pyupgrade pre-commit hooks
- Move documentation from sphinx-rtd-theme to furo

Note the setuptools `reentry_register` hook is no longer possible, although reentry will anyway be removed in aiida v2 (and I never found this to actually work).
Copy link
Member

@ltalirz ltalirz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @chrisjsewell !

Move documentation theme from sphinx-rtd-theme to furo

Why furo?

Note the setuptools reentry_register hook is no longer possible, although reentry is anyway removed in AiiDA v2 (and I never found this to actually work?).

Indeed - e.g. this would anyhow not work when the package was distributed as a wheel, so no worries.

@chrisjsewell
Copy link
Member Author

chrisjsewell commented Jan 18, 2022

Why furo?

It's by me good friend and maintainer of pip; among others their documentation uses it: https://pip.pypa.io
It just looks great. I'm literally looking to see if I can create an extended theme out of it, with the extra bells and whistles that sphinx-book-theme has (like the issue buttons)

Indeed - e.g. this would anyhow not work when the package was distributed as a wheel

Yeh, FYI I see why lots of the packages on aiida-registry didn't include a wheel lol: because the command in publish-on-pypi.yml here was python ./setup.py sdist 😬

@chrisjsewell chrisjsewell changed the title 👌 Refresh Plugin 👌 Refresh template plugin Jan 18, 2022
@chrisjsewell chrisjsewell merged commit 577bf60 into aiidateam:master Jan 18, 2022
@chrisjsewell chrisjsewell deleted the update-flit branch January 18, 2022 09:53
This was referenced Jan 18, 2022
chrisjsewell added a commit to aiidateam/aiida-diff that referenced this pull request Jan 18, 2022
ltalirz pushed a commit to aiidateam/aiida-diff that referenced this pull request Jan 18, 2022
* 👌 Update package

Updated according to aiidateam/aiida-plugin-cutter#88

* Update pyproject.toml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants