✨ NEW: Expose aio_pika.Connection.add_close_callback

[chrisjsewell]

Allow RmqThreadCommunicator to be initialised
with a connection_close_callback.

This is an initial step towards addressing aiidateam/aiida-core#4595 (comment).

Note the aio_pika.RobustConnection class also has an add_reconnect_callback method, but this is not necessary to add if we only want to identify closures (a reconnection is triggered after the close_callbacks have been called).

Note also that when these callbacks are called, all exceptions are caught (see https://github.com/mosquito/aio-pika/blob/94066fa900d9c08624d936f9b94037640267ac37/aio_pika/tools.py#L162-L168) which may provide some challenges if the goal is to except the daemon worker 😒

Oh and one last thing, the callback can be added as "weak=True" (i.e. to a WeakSet) which I'm not sure whether is good to use or not (or to add an additional parameter to control it)

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.34%. Comparing base (cf2e140) to head (803d32b).

Additional details and impacted files

@@             Coverage Diff             @@
##           develop     #104      +/-   ##
===========================================
+ Coverage    90.29%   90.34%   +0.06%     
===========================================
  Files           16       16              
  Lines         1132     1138       +6     
===========================================
+ Hits          1022     1028       +6     
  Misses         110      110              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[muhrin]

Can we change this to be a method e.g. add_close_callback rather than a constructor argument, for a couple of reasons:

1. The number of constructor arguments is already large and getting difficult to look through
2. To decouple construction and use of the class such that clients that get passed an instance can also listen for connection closures.

[chrisjsewell]

Can we change this to be a method

ok done