Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge master into develop (+fixes) #39

Merged
merged 6 commits into from
Oct 17, 2018

Conversation

ltalirz
Copy link
Member

@ltalirz ltalirz commented Oct 17, 2018

PRs #37 and #38 had been done against master by mistake (should have been develop).
Now merging master back into develop here.

Additional Fixes:

  • fix travis test which was still using py instead of pathlib

Next PR will merge develop into master

* fix length of config file name

which could enable install on conda forge

* update yapf and prospector

* disable useless-object-inheritance warning

cannot make pylint happy both in python2 and 3

* fix python3 warnings

 + try to upgrade versions

* try fixing version updater

split setup.py into setup.py and setup.json
(logic was partly written for setup.json, was trying to load
setup.py as json file)

* fix package_data bug

* try fixing install issues

* include setup.json in manifest

* switch to local prospector installation

guykisel mirror was using v0.8 which was breaking pylint on py2.7

* fix prospector version

later versions have incorrect handling of 'quiet' flag for pylint<2
See landscapeio/prospector#266

* fix prospector verison

* updated: remove obsolete setup_version_pat
 + fix to make version updater work properly with setup.json
writing setup.json back was broken when using pathlib
("must be unicode, not str")
@coveralls
Copy link

coveralls commented Oct 17, 2018

Pull Request Test Coverage Report for Build 124

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 68.86%

Totals Coverage Status
Change from base Build 116: 0.0%
Covered Lines: 314
Relevant Lines: 456

💛 - Coveralls

 * dependency should be pathlib2
 * travis tests were still using py
@ltalirz ltalirz merged commit 1d17bfd into aiidateam:develop Oct 17, 2018
@ltalirz ltalirz changed the title Release v1.2.2 dev Merge master into develop (+fixes) Oct 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants