Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Botocore to 1.34.131 #1122

Merged
merged 5 commits into from
Jun 24, 2024
Merged

Conversation

lou-k
Copy link
Contributor

@lou-k lou-k commented Jun 21, 2024

Description of Change

Updates botocore to 1.34.131

There is no added functionality in 1.34.131:

git diff --name-status 1.34.106...1.34.131 botocore/ | grep py$
M	botocore/__init__.py
M	botocore/retries/standard.py
M	botocore/utils.py

but I'd like to use the latest boto3 in my project, and the existing <1.34.107 is causing a dependency issue.

Assumptions

I got some errors on make cov before I made any changes. I'm assuming that is an issue with my local environment and CICD will pass here...

Checklist for All Submissions

  • I have added change info to CHANGES.rst
  • [ ] If this is resolving an issue (needed so future developers can determine if change is still necessary and under what conditions) (can be provided via link to issue with these details):
  • [ ] If this is providing a new feature (can be provided via link to issue with these details):

Checklist when updating botocore and/or aiohttp versions

  • I have read and followed CONTRIBUTING.rst
  • I have updated test_patches.py where/if appropriate (also check if no changes necessary)
  • I have ensured that the awscli/boto3 versions match the updated botocore version

Tests Run Locally

pytest -sv tests/test_patches.py 
 ======================================== test session starts  ========================================
platform darwin -- Python 3.12.3, pytest-8.1.1, pluggy-1.5.0 -- /Users/lou/.local/share/virtualenvs/aiobotocore-UGsiy0fU/bin/python
cachedir: /tmp/pytest_aiobotocore_cache
rootdir: /Users/lou/repos/aiobotocore
configfile: pyproject.toml
plugins: cov-5.0.0, asyncio-0.21.2, xdist-3.5.0
asyncio: mode=Mode.AUTO
collected 2 items                                                                                                                                                                                                                                            

tests/test_patches.py::test_protocol_parsers PASSED
tests/test_patches.py::test_patches Botocore version: 1.34.131
PASSED

 ======================================== 2 passed in 0.20s ========================================

Thanks for the easy-to-follow guide on updating this!

@@ -7,15 +7,15 @@
# NOTE: When updating botocore make sure to update awscli/boto3 versions below
install_requires = [
# pegged to also match items in `extras_require`
'botocore>=1.34.70,<1.34.107',

This comment was marked as resolved.

'aiohttp>=3.9.2,<4.0.0',
'wrapt>=1.10.10, <2.0.0',
'aioitertools>=0.5.1,<1.0.0',
]

extras_require = {
'awscli': ['awscli>=1.32.70,<1.32.107'],

This comment was marked as resolved.

@lou-k
Copy link
Contributor Author

lou-k commented Jun 21, 2024

thanks for the eyes, @jakob-keller !

@jakob-keller
Copy link
Collaborator

closes #1123

@thehesiod
Copy link
Collaborator

oh we hit this error at work, need to upgrade docker/requests IIRC

@thehesiod thehesiod enabled auto-merge (squash) June 24, 2024 17:55
@thehesiod
Copy link
Collaborator

ughh, ci tool

Copy link

codecov bot commented Jun 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.33%. Comparing base (ec33cb7) to head (8eaaa40).
Report is 127 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1122      +/-   ##
==========================================
+ Coverage   86.28%   86.33%   +0.05%     
==========================================
  Files          62       62              
  Lines        5913     5913              
==========================================
+ Hits         5102     5105       +3     
+ Misses        811      808       -3     
Flag Coverage Δ
unittests 86.33% <100.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thehesiod thehesiod merged commit eae9743 into aio-libs:master Jun 24, 2024
12 checks passed
@thehesiod
Copy link
Collaborator

sweet!

@jakob-keller jakob-keller added dependencies Pull requests that update a dependency file and removed deps-update labels Aug 20, 2024
chemelli74 pushed a commit to chemelli74/aiobotocore that referenced this pull request Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants