-
-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Botocore to 1.34.131 #1122
Conversation
@@ -7,15 +7,15 @@ | |||
# NOTE: When updating botocore make sure to update awscli/boto3 versions below | |||
install_requires = [ | |||
# pegged to also match items in `extras_require` | |||
'botocore>=1.34.70,<1.34.107', |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
'aiohttp>=3.9.2,<4.0.0', | ||
'wrapt>=1.10.10, <2.0.0', | ||
'aioitertools>=0.5.1,<1.0.0', | ||
] | ||
|
||
extras_require = { | ||
'awscli': ['awscli>=1.32.70,<1.32.107'], |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
thanks for the eyes, @jakob-keller ! |
closes #1123 |
oh we hit this error at work, need to upgrade docker/requests IIRC |
ughh, ci tool |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1122 +/- ##
==========================================
+ Coverage 86.28% 86.33% +0.05%
==========================================
Files 62 62
Lines 5913 5913
==========================================
+ Hits 5102 5105 +3
+ Misses 811 808 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
sweet! |
Description of Change
Updates botocore to 1.34.131
There is no added functionality in 1.34.131:
but I'd like to use the latest
boto3
in my project, and the existing<1.34.107
is causing a dependency issue.Assumptions
I got some errors on
make cov
before I made any changes. I'm assuming that is an issue with my local environment and CICD will pass here...Checklist for All Submissions
[ ] If this is resolving an issue (needed so future developers can determine if change is still necessary and under what conditions) (can be provided via link to issue with these details):[ ] If this is providing a new feature (can be provided via link to issue with these details):Checklist when updating botocore and/or aiohttp versions
Tests Run Locally
Thanks for the easy-to-follow guide on updating this!