Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a new default docker socket search path #748

Merged
merged 4 commits into from
May 20, 2024

Conversation

achimnol
Copy link
Member

@achimnol achimnol commented Oct 25, 2022

What do these changes do?

  • Add a new docker socket search path used by the Docker Desktop app in macOS.
  • Add support for Docker client contexts (e.g., OrbStack)

Are there changes in behavior for the user?

No impacts to existing users.

Related issue number

This PR resolves #747, #811.

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt
    • The format is <Name> <Surname>.
    • Please keep alphabetical order, the file is sorted by names.
  • Add a new news fragment into the changes folder

@achimnol
Copy link
Member Author

I'm going to conclude this PR now and let a PyCon US sprint participant to do the work for context-path support.

@achimnol achimnol marked this pull request as ready for review May 20, 2024 15:29
@achimnol achimnol enabled auto-merge (squash) May 20, 2024 15:39
@achimnol achimnol merged commit 32fe691 into master May 20, 2024
10 checks passed
@achimnol achimnol deleted the feature/add-default-socket-search-path branch May 20, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add the docker socket path used by Docker Desktop for Mac
1 participant