fix: re-raise RuntimeError when uvloop raises RuntimeError during connect #105
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Its possible that uvloop raises RuntimeError during connect. ie
RuntimeError: File descriptor 59 is used by transport <TCPTransport closed=False reading=True 0x55a6ec5c9460>
. Currently we don't trapRuntimeError
as the code copied fromasyncio.base_events
assumed onlyOSError
can happen. Its possible that selector_events can raiseRuntimeError
as well https://github.com/python/cpython/blob/e44eebfc1eccdaaebc219accbfc705c9a9de068d/Lib/asyncio/selector_events.py#L271 but it doesn't seem to happen in practice as the root cause appears to be a bug inuvloop
. It may be thatloop.sock_connect
is not cancellation safe inuvloop
and is leaking the socket fd allocation on cancel or something else...The file descriptor reuse in
uvloop
is not fixed by this PR. This is something that must be fixed inuvloop
itselfAre there changes in behavior for the user?
no
Related issue number
#93