Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct classifier for license Python-2.0.1 #83

Merged
merged 1 commit into from
Aug 17, 2024

Conversation

tungh2
Copy link
Contributor

@tungh2 tungh2 commented Aug 17, 2024

What do these changes do?

Correct classifier for license Python-2.0.1 according to available classifiers listed at https://pypi.org/classifiers/

Without this patch, pip-licenses disrupted CI license check with below error which was not raised at version prior 2.3.5.

license Other/Proprietary License not in allow-only licenses was found for package aiohappyeyeballs:2.3.6

It seems that the change was made by this commit, which correctly removed CNRI Python License part but unfortunately didn't update properly which is this PR for.

Are there changes in behavior for the user?

There is no change in functionalities except license checking above.

Related issue number

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes

@tungh2
Copy link
Contributor Author

tungh2 commented Aug 17, 2024

@bdraco Hi there, appreciate if you could take a look. The issue is currently blocking our internal CI license checking.

From what I investigated, the fix is sensible in that it made perfect the previous commit as mentioned in the PR description.

@bdraco
Copy link
Member

bdraco commented Aug 17, 2024

I’m not sure the classifier is the same but it’s the nearest match so let’s do it

@bdraco bdraco merged commit 186be05 into aio-libs:main Aug 17, 2024
20 checks passed
Copy link

codecov bot commented Aug 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (30a2dc5) to head (ac46586).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #83   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            4         4           
  Lines          160       160           
  Branches        43        43           
=========================================
  Hits           160       160           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tungh2
Copy link
Contributor Author

tungh2 commented Aug 17, 2024

Thank you, really appreciate your fast approval!

@tungh2
Copy link
Contributor Author

tungh2 commented Aug 19, 2024

Just want to share, the new 2.3.7 release did fix our license check CI 🎉

 aiohappyeyeballs                2.3.7             Other/Proprietary License; Python Software Foundation License 

@apbeers
Copy link

apbeers commented Aug 19, 2024

This fixed my issue too! Thanks so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants