Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle 'Method Not Allowed' on class based views #177

Open
levkovskyi opened this issue Jun 8, 2018 · 4 comments
Open

Handle 'Method Not Allowed' on class based views #177

levkovskyi opened this issue Jun 8, 2018 · 4 comments

Comments

@levkovskyi
Copy link

If method is not allowedCorsViewMixin raise KeyError , and client gets 502 Bad Gateway instead expected 405: Method Not Allowed .

Source code:
https://github.com/aio-libs/aiohttp-cors/blob/master/aiohttp_cors/mixin.py#L28
@asvetlov
Copy link
Member

asvetlov commented Jun 9, 2018

Would you make a bugfix?

@levkovskyi levkovskyi mentioned this issue Jun 11, 2018
Open
@levkovskyi
Copy link
Author

@asvetlov Please check my pull request.

@levkovskyi
Copy link
Author

@asvetlov ping

1 similar comment
@LevZaplatin
Copy link

@asvetlov ping

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@asvetlov @LevZaplatin @levkovskyi