Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 'Method Not Allowed' on class based views #178

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

levkovskyi
Copy link

Fix for #177

@alexmick
Copy link

Sorry for digging this up, any reason to not merge these changes ? Have been coming across this issue a lot lately !

@attie
Copy link

attie commented Feb 14, 2020

Please could we get this merged? I've also run into this issue, and the patch resovles it for me.

This is my use-case:

router = web.RouteTableDef()

@router.view('/my_endpoint')
class MyEndpoint(web.View, CorsViewMixin):

    async def post(self):
        print(self.request)
        raise web.HTTPOk()

When performing a GET against this, the client sees a 500, and the console sees the KeyError.

After applying the patch, the issue is resolved, and the client sees the correct 405.

@tommmlij
Copy link

Is there a plan to merge this?

This is completely breaking using views with the library...

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@Cykooz
Copy link
Member

Cykooz commented Nov 27, 2020

Please, merge this PR. I think that a signing of Contributor License Agreement is not working.
изображение

@tzoiker
Copy link

tzoiker commented Aug 29, 2022

Any chance for merging it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants