Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: explain why all setups we set to app #4137

Closed
Arfey opened this issue Oct 3, 2019 · 5 comments · Fixed by #6163
Closed

docs: explain why all setups we set to app #4137

Arfey opened this issue Oct 3, 2019 · 5 comments · Fixed by #6163
Assignees
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers Hacktoberfest We think it's good for https://hacktoberfest.digitalocean.com/

Comments

@Arfey
Copy link
Member

Arfey commented Oct 3, 2019

Add in documentation part (maybe into tutorial) where explaining why all connection, settings and etс, we add to the instance of application.

example:

async def init_pg(app):
    conf = app['config']['postgres']
    engine = await aiopg.sa.create_engine(
        database=conf['database'],
        user=conf['user'],
        password=conf['password'],
        host=conf['host'],
        port=conf['port'],
        minsize=conf['minsize'],
        maxsize=conf['maxsize'],
    )
    app['db'] = engine

Please don't forget:

  • add screenshot with your part of documentation
  • write below that u want to take it to work
@Arfey Arfey added documentation Improvements or additions to documentation good first issue Good for newcomers Hacktoberfest We think it's good for https://hacktoberfest.digitalocean.com/ labels Oct 3, 2019
@oktak
Copy link

oktak commented Oct 4, 2019

I wonder there exists a website https://demos.aiohttp.org/en/latest/tutorial.html
Is it serving similar purpose? Does this issue aim to merge the two?
Indeed, I am willing to work on this, may be add some screenshots :)
Please let me know more about the direction.

@Arfey
Copy link
Member Author

Arfey commented Oct 4, 2019

Tutorial is story about show how may looks project on aiohttp and how u need to design it. The main documentation is about how work and why.

The main goal of this issue it's describe why we choose this way to share settings and etc.

@asvetlov
Copy link
Member

Can be a part of #4078 work

@sha016
Copy link
Contributor

sha016 commented Oct 28, 2021

@Arfey @asvetlov I'd like to contribute, seems like a good start.

@asvetlov
Copy link
Member

Please do

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers Hacktoberfest We think it's good for https://hacktoberfest.digitalocean.com/
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants