-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HttpParser argument max_headers is not enforced #6721
Labels
Comments
5 tasks
Appears to limit the max size of each header, not the total number of headers: Line 128 in f382b5f
Looks to me like it was part of some functionality that has been completely removed, so the parameter itself should just be removed: |
starflows
pushed a commit
to starflows/aiohttp
that referenced
this issue
Apr 28, 2022
Dreamsorcerer
added a commit
that referenced
this issue
May 9, 2022
* remove unused max_headers (#6721) * Add change description * Update and rename 6721.bugfix to 6721.misc Co-authored-by: Stefan <[email protected]> Co-authored-by: Sam Bull <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
The
max_headers
argument is not used. It does not limit the number of headers allowed in a response.To Reproduce
See the failing unittest
aiohttp/tests/test_client_functional.py
Line 3155 in 188852b
Expected behavior
I assume the argument should limit how many headers a response may have.
I expect the request to fail if too many headers are returned.
Logs/tracebacks
Python Version
aiohttp Version
multidict Version
yarl Version
OS
Arch Linux 5.17.4-arch1-1
Related component
Client
Additional context
No response
Code of Conduct
The text was updated successfully, but these errors were encountered: