Fixed multi-language support URL #248
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In aiohttp0.14.1, when the URL in Chinese characters, will be reported 404 errors when accessing.
In aiohttp0.14.1, when the URL in Chinese characters, will be reported 404 errors when accessing.
| @@ -105,7 +105,7 @@ def create_wsgi_environ(self, message, payload): | |||
| if script_name: | |||
| path_info = path_info.split(script_name, 1)[-1] | |||
|
|
|||
| environ['PATH_INFO'] = path_info | |||
| environ['PATH_INFO'] = unquote(path_info).encode().decode('latin-1') | |||
There was a problem hiding this comment.
Shouldn't here be utf-8 instead of latin-1? Since you turns all multilang chars here into garbage.
|
Right now, I am -1 for that change. I need failing test case that this change fixes |
|
@asvetlov do you think it is possible to extract multilanguage test cases from pyramid? |
|
@fafhrd91 sure. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In aiohttp0.14.1, when the URL in Chinese characters, will be reported 404 errors when accessing. Such modifications do then you can solve this problem