App cleanup context

[asvetlov]

A fix for #2092

[codecov-io]

Codecov Report

Merging #2747 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #2747      +/-   ##
==========================================
+ Coverage   97.98%   97.99%   +<.01%     
==========================================
  Files          39       39              
  Lines        7391     7423      +32     
  Branches     1299     1304       +5     
==========================================
+ Hits         7242     7274      +32     
  Misses         47       47              
  Partials      102      102

Impacted Files	Coverage Δ
aiohttp/web.py	98.79% <100%> (ø)	⬆️
aiohttp/web_app.py	99.08% <100%> (+0.15%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 185ab31...1918663. Read the comment docs.

[asvetlov]

The feature is done (except documentation).
The only questionable thing is the new signal name.
Now it is app.on_cleanup_ctx.
Suggestions?

[asvetlov]

@aio-libs/aiohttp-committers please take a look.
If nobody will invite a better name than app.on_cleanup_ctx I'll merge the PR after adding a documentation for the feature.

[kxepal]

I don't see any app.on_cleanup_ctx around in this PR, but app.cleanup_ctx fits nice.

[asvetlov]

Sorry, it is definitely app.cleanup_ctx property.

[kxepal]

It has a good name since it refrect exactly what it reference to - CleanupContext. It's hard to figure something better for me. Why do you question this name? Do you have any different ideas about?

[asvetlov]

No other ideas actually.
But I was not sure, maybe somebody can suggest something better?

[code-cro]

I suggest full name cleanup_context to be more clear for the reader.

[asvetlov]

Thanks for sharing opinion. Ctx is pretty common abbreviation.
Python uses such shortcuts everywhere in stdlib.
cleanup_context is really long name

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a [new issue] for related bugs.
If you feel like there's important points made in this discussion, please include those exceprts into that [new issue].
[new issue]: https://github.com/aio-libs/aiohttp/issues/new