Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace ClientResponseError.code with .status #2781

Closed
asvetlov opened this issue Feb 28, 2018 · 1 comment
Closed

Replace ClientResponseError.code with .status #2781

asvetlov opened this issue Feb 28, 2018 · 1 comment
Labels
client good first issue Good for newcomers outdated
Milestone
3.1

Comments

@asvetlov
Copy link
Member

To keep similarity with response classes.
.code should be a deprecated property.

The issue is trivial, volunteer is welcome.
@asvetlov asvetlov added good first issue Good for newcomers client labels Feb 28, 2018
livercat pushed a commit to livercat/aiohttp that referenced this issue Mar 9, 2018
Fix aio-libs#2781: deprecate ClientResponseError.code in favor of .st…
ac48469 
…atus
livercat pushed a commit to livercat/aiohttp that referenced this issue Mar 9, 2018
Fix aio-libs#2781: deprecate ClientResponseError.code in favor of .st…
def302a 
…atus
@livercat livercat mentioned this issue Mar 9, 2018
Merged
5 tasks
@asvetlov asvetlov added this to the 3.1 milestone Mar 9, 2018
This was referenced Mar 22, 2018
Closed
Closed
@aio-libs-bot aio-libs-bot mentioned this issue Dec 12, 2018
Closed
@lock
Copy link

lock bot commented Oct 28, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a [new issue] for related bugs.
If you feel like there's important points made in this discussion, please include those exceprts into that [new issue].
[new issue]: https://github.com/aio-libs/aiohttp/issues/new

@lock lock bot added the outdated label Oct 28, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
client good first issue Good for newcomers outdated
Projects
None yet
Milestone
3.1
Development

No branches or pull requests
1 participant
@asvetlov