Fix #2781: deprecate ClientResponseError.code in favor of .status

[livercat]

What do these changes do?

Deprecate ClientResponseError.code in favor of .status

Are there changes in behavior for the user?

ClientResponseError.code is deprecated, but continues to work

Related issue number

#2781

Checklist

• I think the code is well written
• Unit tests for the changes exist
• Documentation reflects the changes
• If you provide code modification, please add yourself to CONTRIBUTORS.txt
  • The format is <Name> <Surname>.
  • Please keep alphabetical order, the file is sorted by names.
• Add a new news fragment into the CHANGES folder
  • name it <issue_id>.<type> for example (588.bugfix)
  • if you don't have an issue_id change it to the pr id after creating the pr
  • ensure type is one of the following:
    • .feature: Signifying a new feature.
    • .bugfix: Signifying a bug fix.
    • .doc: Signifying a documentation improvement.
    • .removal: Signifying a deprecation or removal of public API.
    • .misc: A ticket has been closed, but it is not of interest to users.
  • Make sure to use full sentences with correct case and punctuation, for example: "Fix issue with non-ascii contents in doctest text files."

[codecov-io]

Codecov Report

Merging #2818 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #2818      +/-   ##
==========================================
+ Coverage   97.97%   97.98%   +<.01%     
==========================================
  Files          39       39              
  Lines        7376     7391      +15     
  Branches     1295     1299       +4     
==========================================
+ Hits         7227     7242      +15     
  Misses         47       47              
  Partials      102      102

Impacted Files	Coverage Δ
aiohttp/client_reqrep.py	97.24% <ø> (ø)	⬆️
aiohttp/connector.py	96.82% <ø> (ø)	⬆️
aiohttp/client_exceptions.py	95.6% <100%> (+0.86%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1bfc54b...50253e0. Read the comment docs.

[asvetlov]

Thanks for contribution.
Please add a case when both status and code are passed to constructor and update documentation: https://docs.aiohttp.org/en/stable/client_reference.html#aiohttp.ClientResponseError

[asvetlov]

Please add two a couple lines for raising ValueError if both code and status are provided

[livercat]

Done.

[asvetlov]

Code is good, docs are left

[asvetlov]

Thanks!

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a [new issue] for related bugs.
If you feel like there's important points made in this discussion, please include those exceprts into that [new issue].
[new issue]: https://github.com/aio-libs/aiohttp/issues/new