-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate app.make_handler() #2938
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2938 +/- ##
==========================================
+ Coverage 97.99% 97.99% +<.01%
==========================================
Files 40 40
Lines 7513 7523 +10
Branches 1318 1318
==========================================
+ Hits 7362 7372 +10
Misses 48 48
Partials 103 103
Continue to review full report at Codecov.
|
aiohttp/web_app.py
Outdated
loop=None, | ||
access_log_class=AccessLogger, | ||
**kwargs): | ||
warnings.warn("@make_handler is deprecated", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please replace @make_handler
with Application.make_handler(...)
and add a test for making sure that deprecation warning is raised.
docs/logging.rst
Outdated
@@ -32,6 +32,7 @@ Access log by default is switched on and uses ``'aiohttp.access'`` | |||
logger name. | |||
|
|||
The log may be controlled by :meth:`aiohttp.web.Application.make_handler` call. | |||
.. deprecated:: 3.2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove the deprecation but replace aiohttp.web.Application.make_handler
with aiohttp.web.AppRunner
/ aiohttp.web.run_app()
docs/logging.rst
Outdated
@@ -123,7 +124,7 @@ The log is enabled by default. | |||
To use different logger name please specify *logger* parameter | |||
(:class:`logging.Logger` instance) on performing | |||
:meth:`aiohttp.web.Application.make_handler` call. | |||
|
|||
.. deprecated:: 3.2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The same
Thanks! |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a [new issue] for related bugs. |
What do these changes do?
Deprecate the use of Application.make_handler()
Are there changes in behavior for the user?
Related issue number
#2875
Checklist
CONTRIBUTORS.txt
CHANGES
folder<issue_id>.<type>
for example (588.bugfix)issue_id
change it to the pr id after creating the pr.feature
: Signifying a new feature..bugfix
: Signifying a bug fix..doc
: Signifying a documentation improvement..removal
: Signifying a deprecation or removal of public API..misc
: A ticket has been closed, but it is not of interest to users.