Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes some bugs in the limit connection feature #2964

Merged
merged 12 commits into from
May 4, 2018

Commits on Apr 28, 2018

  1. Fixes some bugs in the limit connection feature

    There are two places which try to release the next waiter, when the
    ongoing connection is being canceled and we call explicitly to wake up
    a waiter or when the connection is being released. In both situations we
    call the same method `_release_waiter` that will iterate per all of the
    queues till found one that has a waiter that is not already canceled.
    
    This iteration will also check that the limit and the limit per host is
    not overcomed. The logic to check how many available connections/free
    slots there are has been placed behind the `_available_connections`
    function.
    
    So far this PR fixes:
    
    - Take into account the limit and limit per host at any time that we try
    to wake up a waiter. No availables, no wake up.
    - Dont give up till reach a waiter that is not finished.
    - Iterate always through all of the different hosts.
    
    What is missing:
    
    - More coverage
    - Shuffle the keys to give always the same chances to all of the hosts?
    pfreixes committed Apr 28, 2018
    Configuration menu
    Copy the full SHA
    caea886 View commit details
    Browse the repository at this point in the history
  2. Added changes file

    pfreixes committed Apr 28, 2018
    Configuration menu
    Copy the full SHA
    58495e3 View commit details
    Browse the repository at this point in the history

Commits on Apr 29, 2018

  1. Refine some tests

    pfreixes committed Apr 29, 2018
    Configuration menu
    Copy the full SHA
    96acca9 View commit details
    Browse the repository at this point in the history

Commits on May 1, 2018

  1. Configuration menu
    Copy the full SHA
    199b2bd View commit details
    Browse the repository at this point in the history

Commits on May 2, 2018

  1. Fixes some useless code

    pfreixes committed May 2, 2018
    Configuration menu
    Copy the full SHA
    b94c684 View commit details
    Browse the repository at this point in the history
  2. Increse coverage

    pfreixes committed May 2, 2018
    Configuration menu
    Copy the full SHA
    ad92b5e View commit details
    Browse the repository at this point in the history

Commits on May 3, 2018

  1. Configuration menu
    Copy the full SHA
    9e54abf View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    38011f4 View commit details
    Browse the repository at this point in the history
  3. Increase coverage

    pfreixes committed May 3, 2018
    Configuration menu
    Copy the full SHA
    ab2a5f6 View commit details
    Browse the repository at this point in the history
  4. Fix test

    pfreixes committed May 3, 2018
    Configuration menu
    Copy the full SHA
    69bf66a View commit details
    Browse the repository at this point in the history

Commits on May 4, 2018

  1. Configuration menu
    Copy the full SHA
    9e958ff View commit details
    Browse the repository at this point in the history
  2. Fix test

    pfreixes committed May 4, 2018
    Configuration menu
    Copy the full SHA
    ff39bb8 View commit details
    Browse the repository at this point in the history