-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes some bugs in the limit connection feature #2964
Merged
Merged
Commits on Apr 28, 2018
-
Fixes some bugs in the limit connection feature
There are two places which try to release the next waiter, when the ongoing connection is being canceled and we call explicitly to wake up a waiter or when the connection is being released. In both situations we call the same method `_release_waiter` that will iterate per all of the queues till found one that has a waiter that is not already canceled. This iteration will also check that the limit and the limit per host is not overcomed. The logic to check how many available connections/free slots there are has been placed behind the `_available_connections` function. So far this PR fixes: - Take into account the limit and limit per host at any time that we try to wake up a waiter. No availables, no wake up. - Dont give up till reach a waiter that is not finished. - Iterate always through all of the different hosts. What is missing: - More coverage - Shuffle the keys to give always the same chances to all of the hosts?
Configuration menu - View commit details
-
Copy full SHA for caea886 - Browse repository at this point
Copy the full SHA caea886View commit details -
Configuration menu - View commit details
-
Copy full SHA for 58495e3 - Browse repository at this point
Copy the full SHA 58495e3View commit details
Commits on Apr 29, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 96acca9 - Browse repository at this point
Copy the full SHA 96acca9View commit details
Commits on May 1, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 199b2bd - Browse repository at this point
Copy the full SHA 199b2bdView commit details
Commits on May 2, 2018
-
Configuration menu - View commit details
-
Copy full SHA for b94c684 - Browse repository at this point
Copy the full SHA b94c684View commit details -
Configuration menu - View commit details
-
Copy full SHA for ad92b5e - Browse repository at this point
Copy the full SHA ad92b5eView commit details
Commits on May 3, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 9e54abf - Browse repository at this point
Copy the full SHA 9e54abfView commit details -
Configuration menu - View commit details
-
Copy full SHA for 38011f4 - Browse repository at this point
Copy the full SHA 38011f4View commit details -
Configuration menu - View commit details
-
Copy full SHA for ab2a5f6 - Browse repository at this point
Copy the full SHA ab2a5f6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 69bf66a - Browse repository at this point
Copy the full SHA 69bf66aView commit details
Commits on May 4, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 9e958ff - Browse repository at this point
Copy the full SHA 9e958ffView commit details -
Configuration menu - View commit details
-
Copy full SHA for ff39bb8 - Browse repository at this point
Copy the full SHA ff39bb8View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.