Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix iter_chunks type hint (#3230) #3232

Merged
merged 3 commits into from
Sep 1, 2018
Merged

Conversation

dfroger
Copy link
Contributor

@dfroger dfroger commented Aug 31, 2018

Not sure it's ok to modify working code in order to fix type hints?

@codecov-io
Copy link

codecov-io commented Sep 1, 2018

Codecov Report

Merging #3232 into master will decrease coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3232      +/-   ##
==========================================
- Coverage   98.11%   98.07%   -0.04%     
==========================================
  Files          43       43              
  Lines        7853     7857       +4     
  Branches     1354     1354              
==========================================
+ Hits         7705     7706       +1     
- Misses         57       59       +2     
- Partials       91       92       +1
Impacted Files Coverage Δ
aiohttp/streams.py 99.2% <100%> (ø) ⬆️
aiohttp/tcp_helpers.py 90% <0%> (-6.67%) ⬇️
aiohttp/client_reqrep.py 97.47% <0%> (-0.17%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 03d83b0...b25802a. Read the comment docs.

Copy link
Member

@asvetlov asvetlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@asvetlov asvetlov merged commit 026edc4 into aio-libs:master Sep 1, 2018
asvetlov pushed a commit that referenced this pull request Sep 1, 2018
@lock
Copy link

lock bot commented Oct 28, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a [new issue] for related bugs.
If you feel like there's important points made in this discussion, please include those exceprts into that [new issue].
[new issue]: https://github.com/aio-libs/aiohttp/issues/new

@lock lock bot added the outdated label Oct 28, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants