[3.6] Reset the sock_read timeout when data arrives (#4142) #4143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Reset the sock_read timeout when data arrives The sock_read timeout should apply *per read operation*, but currently applies cumulatively across all reads. Reschedule the timeout each time data is received and add tests to validate that the timeout doesn't interfere with overall reading and correctly catches reads that take too long. * Add myself to the contributors list * Add a towncrier change description (cherry picked from commit ecb1b6b) Co-authored-by: Martijn Pieters <[email protected]>
psf-chronographer
bot
added
the
bot:chronographer:provided
Codecov Report
@@ Coverage Diff @@
## 3.6 #4143 +/- ##
=========================================
- Coverage 98.1% 98.06% -0.05%
=========================================
Files 44 44
Lines 8871 8872 +1
Branches 1391 1391
=========================================
- Hits 8703 8700 -3
- Misses 63 66 +3
- Partials 105 106 +1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The sock_read timeout should apply per read operation, but currently applies
cumulatively across all reads. Reschedule the timeout each time data is
received and add tests to validate that the timeout doesn't interfere with
overall reading and correctly catches reads that take too long.
(cherry picked from commit ecb1b6b)
Co-authored-by: Martijn Pieters [email protected]