Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #4012 Updated the docs to reflect need of decoding filename #5831

Closed
wants to merge 3 commits into from
Closed

Issue #4012 Updated the docs to reflect need of decoding filename #5831

wants to merge 3 commits into from

Conversation

tusharsnx
Copy link

@tusharsnx tusharsnx commented Jun 24, 2021

In the current version, the filenames are encoded before sending the files to the server when using FormData() object. This problem has already been posted in #4012. Its fix has been discussed in #4031 will be added in aiohttp v3.8. Updated the docs to help users know the problem and its fix for now.

What do these changes do?

Updated the docs to help users know the problem and its fix for now.

Are there changes in behavior for the user?

Improved docs for the stable version

Related issue number

related to #4012

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt
    • The format is <Name> <Surname>.
    • Please keep alphabetical order, the file is sorted by names.
  • Add a new news fragment into the CHANGES folder
    • name it <issue_id>.<type> for example (588.bugfix)
    • if you don't have an issue_id change it to the pr id after creating the pr
    • ensure type is one of the following:
      • .feature: Signifying a new feature.
      • .bugfix: Signifying a bug fix.
      • .doc: Signifying a documentation improvement.
      • .removal: Signifying a deprecation or removal of public API.
      • .misc: A ticket has been closed, but it is not of interest to users.
    • Make sure to use full sentences with correct case and punctuation, for example: "Fix issue with non-ascii contents in doctest text files."

In the current version, the filenames are encoded before sending the files to the server when using FormData() object. This problem has already been posted in #4012. Its fix has been discussed in #4031 will be added in aiohttp v3.8. Updated the docs to help users know the problem and its fix for now.
@tusharsnx tusharsnx changed the title Updated the docs to reflect need of decoding filename issue #4012 Issue #4012 Updated the docs to reflect need of decoding filename Jun 24, 2021
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Jun 24, 2021
@asvetlov
Copy link
Member

Thanks for the PR.
aiohttp 3.8 will be released soon with the proper fix (already landed)

@asvetlov asvetlov closed this Oct 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants