[PR #5557/bb4ee18d backport][3.8] test_proxy_from_env did not clear proxies already set in the #6184
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of PR #5557 as merged into master (bb4ee18).
environment. Added code to first clear proxies that were already set.
Refactored the parametrize input on test_proxy_from_env to work more like test_get_env_proxy_for_url to be consistent.
(cherry picked from commit bb4ee18)
What do these changes do?
Fix failing tests when a environment proxy is set.
test_proxy_from_env did not clear proxies already set in the environment. Added code to first clear proxies that were already set.
Refactored the parametrize input on test_proxy_from_env to work more like test_get_env_proxy_for_url to be consistent.
Are there changes in behavior for the user?
No.
Related issue number
#5554
Checklist
CONTRIBUTORS.txt
CHANGES
folder<issue_id>.<type>
for example (588.bugfix)issue_id
change it to the pr id after creating the pr.feature
: Signifying a new feature..bugfix
: Signifying a bug fix..doc
: Signifying a documentation improvement..removal
: Signifying a deprecation or removal of public API..misc
: A ticket has been closed, but it is not of interest to users.