-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bump llhttp to v8.1.1 #7367
Conversation
Codecov Report
@@ Coverage Diff @@
## master #7367 +/- ##
=======================================
Coverage 97.27% 97.27%
=======================================
Files 106 106
Lines 31402 31411 +9
Branches 3925 3927 +2
=======================================
+ Hits 30547 30556 +9
Misses 650 650
Partials 205 205
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
@Dreamsorcerer I think there was a change note file that needs updating. One of the recent ones. |
I don't think anything needs updating from your previous note: https://github.com/aio-libs/aiohttp/blob/master/CHANGES/7346.feature The change you applied just didn't work, this PR fixes it (as evidenced by the test not failing in your PR). The version is still 8.1.1. |
So I suppose this is mergeable, but it'd be nice to think about those nitpicks... |
Backport to 3.8: 💔 cherry-picking failed — conflicts found❌ Failed to cleanly apply 41e2c4c on top of patchback/backports/3.8/41e2c4c1fdf34d800bb9e4247cd9ebfc6904d9d7/pr-7367 Backporting merged PR #7367 into master
🤖 @patchback |
Backport to 3.9: 💔 cherry-picking failed — conflicts found❌ Failed to cleanly apply 41e2c4c on top of patchback/backports/3.9/41e2c4c1fdf34d800bb9e4247cd9ebfc6904d9d7/pr-7367 Backporting merged PR #7367 into master
🤖 @patchback |
(cherry picked from commit 41e2c4c)
(cherry picked from commit 41e2c4c)
No description provided.