[PR #8163/006fbe03 backport][3.9] Avoid creating a task to do DNS resolution if there is no throttle #8172
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of PR #8163 as merged into master (006fbe0).
What do these changes do?
Avoid creating a task to do dns resolution if there is no throttle
When doing some debugging, I noticed that a large amount of tasks created on a Home Assistant instance were
TCPConnector._resolve_host
for cases where the host was an ip address or already in the cache. On this instance, it reduced the number of_resolve_host
tasks by 99%. Previously I observed ~500 per minute.Are there changes in behavior for the user?
There is a small performance improvement on cache hit and when the host is an ip address. Since requests no longer have to suspend on cache hit this can reduce latency of requests. Scheduling and awaiting a task on the event loop can take 2 order of magnitude more wall clock time vs running a simple function.
Is it a substantial burden for the maintainers to support this?
no
Related issue number
Checklist
CONTRIBUTORS.txt
CHANGES/
foldername it
<issue_or_pr_num>.<type>.rst
(e.g.588.bugfix.rst
)if you don't have an issue number, change it to the pull request
number after creating the PR
.bugfix
: A bug fix for something the maintainers deemed animproper undesired behavior that got corrected to match
pre-agreed expectations.
.feature
: A new behavior, public APIs. That sort of stuff..deprecation
: A declaration of future API removals and breakingchanges in behavior.
.breaking
: When something public is removed in a breaking way.Could be deprecated in an earlier release.
.doc
: Notable updates to the documentation structure or buildprocess.
.packaging
: Notes for downstreams about unobvious side effectsand tooling. Changes in the test invocation considerations and
runtime assumptions.
.contrib
: Stuff that affects the contributor experience. e.g.Running tests, building the docs, setting up the development
environment.
.misc
: Changes that are hard to assign to any of the abovecategories.
Make sure to use full sentences with correct case and punctuation,
for example:
Use the past tense or the present tense a non-imperative mood,
referring to what's changed compared to the last released version
of this project.