Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix multipart reading with split boundary #8657

Merged
merged 5 commits into from
Aug 8, 2024
Merged

Fix multipart reading with split boundary #8657

merged 5 commits into from
Aug 8, 2024

Conversation

Dreamsorcerer
Copy link
Member

@Dreamsorcerer Dreamsorcerer commented Aug 8, 2024 •
edited
Loading

Fixes #8643.

@Dreamsorcerer Dreamsorcerer added backport-3.10 Trigger automatic backporting to the 3.10 release branch by Patchback robot backport-3.11 Trigger automatic backporting to the 3.11 release branch by Patchback robot labels Aug 8, 2024
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Aug 8, 2024
bdraco
bdraco approved these changes Aug 8, 2024
View reviewed changes
Copy link
Member

@bdraco bdraco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov Codecov
Copy link

codecov bot commented Aug 8, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.97%. Comparing base (51d872e) to head (b157abf).
Report is 850 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #8657   +/-   ##
=======================================
  Coverage   97.96%   97.97%           
=======================================
  Files         107      107           
  Lines       33708    33780   +72     
  Branches     3957     3966    +9     
=======================================
+ Hits        33023    33096   +73     
  Misses        507      507           
+ Partials      178      177    -1
Flag Coverage Δ
CI-GHA 97.88% <100.00%> (+<0.01%) ⬆️
OS-Linux 97.54% <100.00%> (+<0.01%) ⬆️
OS-Windows 95.91% <100.00%> (+<0.01%) ⬆️
OS-macOS 97.20% <100.00%> (+<0.01%) ⬆️
Py-3.10.11 97.35% <100.00%> (+<0.01%) ⬆️
Py-3.10.14 97.28% <100.00%> (+<0.01%) ⬆️
Py-3.11.9 97.51% <100.00%> (+<0.01%) ⬆️
Py-3.12.4 97.63% <100.00%> (+<0.01%) ⬆️
Py-3.8.10 95.56% <21.56%> (-0.12%) ⬇️
Py-3.8.18 97.07% <21.56%> (-0.11%) ⬇️
Py-3.9.13 97.22% <21.56%> (-0.12%) ⬇️
Py-3.9.19 97.16% <21.56%> (-0.11%) ⬇️
Py-pypy7.3.16 96.75% <21.56%> (-0.11%) ⬇️
VM-macos 97.20% <100.00%> (+<0.01%) ⬆️
VM-ubuntu 97.54% <100.00%> (+<0.01%) ⬆️
VM-windows 95.91% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Dreamsorcerer Dreamsorcerer merged commit 6c6ecfa into master Aug 8, 2024
37 of 38 checks passed
@Dreamsorcerer Dreamsorcerer deleted the fix-multipart-boundary-split branch August 8, 2024 20:37
@patchback Patchback
Copy link
Contributor

patchback bot commented Aug 8, 2024 •
edited
Loading

Backport to 3.10: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.10/6c6ecfaf320b27eb9f86066c4bfb1f3947c3362d/pr-8657

Backported as #8658

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Aug 8, 2024
@Dreamsorcerer @patchback
Fix multipart reading with split boundary (#8657)
cf2757d 
(cherry picked from commit 6c6ecfa)
@patchback patchback bot mentioned this pull request Aug 8, 2024
Merged
@patchback Patchback
Copy link
Contributor

patchback bot commented Aug 8, 2024 •
edited
Loading

Backport to 3.11: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.11/6c6ecfaf320b27eb9f86066c4bfb1f3947c3362d/pr-8657

Backported as #8659

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Aug 8, 2024
@Dreamsorcerer @patchback
Fix multipart reading with split boundary (#8657)
e29230e 
(cherry picked from commit 6c6ecfa)
@patchback patchback bot mentioned this pull request Aug 8, 2024
Merged
Dreamsorcerer added a commit that referenced this pull request Aug 8, 2024
@patchback @Dreamsorcerer
[PR #8657/6c6ecfaf backport][3.10] Fix multipart reading with split b…
1bc8d53 
…oundary (#8658)

**This is a backport of PR #8657 as merged into master
(6c6ecfa).**

---------

Co-authored-by: Sam Bull <[email protected]>
Dreamsorcerer added a commit that referenced this pull request Aug 8, 2024
@patchback @Dreamsorcerer
[PR #8657/6c6ecfaf backport][3.11] Fix multipart reading with split b…
dbaf174 
…oundary (#8659)

**This is a backport of PR #8657 as merged into master
(6c6ecfa).**

---------

Co-authored-by: Sam Bull <[email protected]>
@bdraco bdraco added this to the 3.10.3 milestone Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdraco bdraco bdraco approved these changes

@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

@webknjaz webknjaz Awaiting requested review from webknjaz webknjaz is a code owner

Assignees
No one assigned
Labels
backport-3.10 Trigger automatic backporting to the 3.10 release branch by Patchback robot backport-3.11 Trigger automatic backporting to the 3.11 release branch by Patchback robot bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Milestone
3.10.3
Development

Successfully merging this pull request may close these issues.

Multipart reader fails on Transfer-Encoding: chunked
2 participants
@Dreamsorcerer @bdraco