Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid creating handler waiter until shutdown #9168

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Sep 17, 2024

What do these changes do?

Every request created _handler_waiter. Instead only create it when we need to wait for graceful shutdown. Avoids one future creation for every request if we are not shutting down.

Are there changes in behavior for the user?

no

Is it a substantial burden for the maintainers to support this?

no

related issue #2779

profile

before
handle_request_before

after
handle_request_after

Every request created _handler_waiter. Instead only create it
when we need to wait for graceful shutdown
@bdraco bdraco added backport-3.10 Trigger automatic backporting to the 3.10 release branch by Patchback robot backport-3.11 Trigger automatic backporting to the 3.11 release branch by Patchback robot labels Sep 17, 2024
Copy link

codecov bot commented Sep 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.31%. Comparing base (98b363e) to head (94fcfef).
Report is 1 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #9168   +/-   ##
=======================================
  Coverage   98.31%   98.31%           
=======================================
  Files         107      107           
  Lines       34485    34489    +4     
  Branches     4095     4096    +1     
=======================================
+ Hits        33903    33907    +4     
  Misses        411      411           
  Partials      171      171           
Flag Coverage Δ
CI-GHA 98.20% <100.00%> (+<0.01%) ⬆️
OS-Linux 97.87% <100.00%> (+<0.01%) ⬆️
OS-Windows 96.28% <100.00%> (+<0.01%) ⬆️
OS-macOS 97.54% <100.00%> (+<0.01%) ⬆️
Py-3.10.11 97.64% <100.00%> (+<0.01%) ⬆️
Py-3.10.14 97.58% <100.00%> (+<0.01%) ⬆️
Py-3.11.10 97.47% <100.00%> (?)
Py-3.11.9 97.53% <100.00%> (-0.28%) ⬇️
Py-3.12.5 97.58% <100.00%> (+<0.01%) ⬆️
Py-3.12.6 97.64% <100.00%> (+<0.01%) ⬆️
Py-3.9.13 97.53% <100.00%> (+<0.01%) ⬆️
Py-3.9.19 97.47% <100.00%> (+<0.01%) ⬆️
Py-pypy7.3.16 97.08% <100.00%> (+<0.01%) ⬆️
VM-macos 97.54% <100.00%> (+<0.01%) ⬆️
VM-ubuntu 97.87% <100.00%> (+<0.01%) ⬆️
VM-windows 96.28% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Sep 18, 2024
@bdraco bdraco marked this pull request as ready for review September 18, 2024 05:51
aiohttp/web_protocol.py Outdated Show resolved Hide resolved
aiohttp/web_protocol.py Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-3.10 Trigger automatic backporting to the 3.10 release branch by Patchback robot backport-3.11 Trigger automatic backporting to the 3.11 release branch by Patchback robot bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants