Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve performance of starting web requests when content length is not set #9172

Merged
merged 7 commits into from
Sep 18, 2024

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Sep 18, 2024

What do these changes do?

Reorder the start logic to avoid the check to remove content length if its not present

Are there changes in behavior for the user?

no

Is it a substantial burden for the maintainers to support this?

no

related issue #2779

before
start_before

after
start_after

Reorder the start logic to avoid the check to remove
content length if its not present

related issue #2779
@bdraco bdraco added backport-3.10 Trigger automatic backporting to the 3.10 release branch by Patchback robot backport-3.11 Trigger automatic backporting to the 3.11 release branch by Patchback robot labels Sep 18, 2024
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Sep 18, 2024
Copy link

codecov bot commented Sep 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.31%. Comparing base (98b363e) to head (13d7adf).
Report is 1 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #9172   +/-   ##
=======================================
  Coverage   98.31%   98.31%           
=======================================
  Files         107      107           
  Lines       34485    34496   +11     
  Branches     4095     4095           
=======================================
+ Hits        33903    33916   +13     
+ Misses        411      410    -1     
+ Partials      171      170    -1     
Flag Coverage Δ
CI-GHA 98.21% <100.00%> (+<0.01%) ⬆️
OS-Linux 97.87% <100.00%> (+<0.01%) ⬆️
OS-Windows 96.29% <100.00%> (+<0.01%) ⬆️
OS-macOS 97.55% <100.00%> (+<0.01%) ⬆️
Py-3.10.11 97.65% <100.00%> (+<0.01%) ⬆️
Py-3.10.14 97.49% <100.00%> (-0.09%) ⬇️
Py-3.10.15 97.40% <100.00%> (?)
Py-3.11.9 97.81% <100.00%> (+<0.01%) ⬆️
Py-3.12.5 97.59% <100.00%> (+<0.01%) ⬆️
Py-3.12.6 97.65% <100.00%> (+<0.01%) ⬆️
Py-3.9.13 97.54% <100.00%> (+<0.01%) ⬆️
Py-3.9.19 97.39% <100.00%> (-0.09%) ⬇️
Py-3.9.20 97.29% <100.00%> (?)
Py-pypy7.3.16 97.09% <100.00%> (+<0.01%) ⬆️
VM-macos 97.55% <100.00%> (+<0.01%) ⬆️
VM-ubuntu 97.87% <100.00%> (+<0.01%) ⬆️
VM-windows 96.29% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco bdraco marked this pull request as ready for review September 18, 2024 06:55
@bdraco
Copy link
Member Author

bdraco commented Sep 18, 2024

Looks like we are missing coverage for this case but it was not obvious before

@bdraco bdraco marked this pull request as draft September 18, 2024 06:56
@bdraco bdraco marked this pull request as ready for review September 18, 2024 14:40
tests/test_web_response.py Outdated Show resolved Hide resolved
@bdraco bdraco enabled auto-merge (squash) September 18, 2024 14:41
@bdraco bdraco changed the title Improve performance of starting web requests Improve performance of starting web requests when content length is not set Sep 18, 2024
@bdraco bdraco merged commit b93ef57 into master Sep 18, 2024
31 of 32 checks passed
@bdraco bdraco deleted the improve_perf_start branch September 18, 2024 15:35
Copy link
Contributor

patchback bot commented Sep 18, 2024

Backport to 3.10: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.10/b93ef57cce9ea95954d17b7e4ca11883a4da2471/pr-9172

Backported as #9192

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

Copy link
Contributor

patchback bot commented Sep 18, 2024

Backport to 3.11: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.11/b93ef57cce9ea95954d17b7e4ca11883a4da2471/pr-9172

Backported as #9193

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Sep 18, 2024
bdraco added a commit that referenced this pull request Sep 18, 2024
…b requests when content length is not set (#9192)

Co-authored-by: J. Nick Koston <[email protected]>
bdraco added a commit that referenced this pull request Sep 18, 2024
…b requests when content length is not set (#9193)

Co-authored-by: J. Nick Koston <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-3.10 Trigger automatic backporting to the 3.10 release branch by Patchback robot backport-3.11 Trigger automatic backporting to the 3.11 release branch by Patchback robot bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants