Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid calling response prepare hook if its empty #9173

Merged
merged 2 commits into from
Sep 18, 2024
Merged

Avoid calling response prepare hook if its empty #9173

merged 2 commits into from
Sep 18, 2024

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Sep 18, 2024

What do these changes do?

Avoid calling response prepare hook if its empty as its likely to be empty in most cases

Are there changes in behavior for the user?

no

Is it a substantial burden for the maintainers to support this?

no

related issue #2779

before
prepare_hook_before

after
prepare_hook_after

@bdraco bdraco added backport-3.10 Trigger automatic backporting to the 3.10 release branch by Patchback robot backport-3.11 Trigger automatic backporting to the 3.11 release branch by Patchback robot labels Sep 18, 2024
@codecov Codecov
Copy link

codecov bot commented Sep 18, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.31%. Comparing base (bf022b3) to head (0d98cbe).
Report is 6 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #9173   +/-   ##
=======================================
  Coverage   98.31%   98.31%           
=======================================
  Files         107      107           
  Lines       34483    34484    +1     
  Branches     4093     4094    +1     
=======================================
+ Hits        33901    33902    +1     
  Misses        411      411           
  Partials      171      171
Flag Coverage Δ
CI-GHA 98.20% <100.00%> (+<0.01%) ⬆️
OS-Linux 97.87% <100.00%> (+<0.01%) ⬆️
OS-Windows 96.28% <100.00%> (+<0.01%) ⬆️
OS-macOS 97.54% <100.00%> (+<0.01%) ⬆️
Py-3.10.11 97.64% <100.00%> (+<0.01%) ⬆️
Py-3.10.14 97.49% <100.00%> (-0.09%) ⬇️
Py-3.10.15 97.39% <100.00%> (-0.14%) ⬇️
Py-3.11.10 97.28% <100.00%> (?)
Py-3.11.9 97.72% <100.00%> (-0.09%) ⬇️
Py-3.12.5 97.58% <100.00%> (+<0.01%) ⬆️
Py-3.12.6 97.64% <100.00%> (+<0.01%) ⬆️
Py-3.9.13 97.53% <100.00%> (+<0.01%) ⬆️
Py-3.9.19 97.47% <100.00%> (+<0.01%) ⬆️
Py-3.9.20 ?
Py-pypy7.3.16 97.08% <100.00%> (+<0.01%) ⬆️
VM-macos 97.54% <100.00%> (+<0.01%) ⬆️
VM-ubuntu 97.87% <100.00%> (+<0.01%) ⬆️
VM-windows 96.28% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Sep 18, 2024
@bdraco bdraco marked this pull request as ready for review September 18, 2024 07:13
@bdraco bdraco merged commit d3c3c6a into master Sep 18, 2024
35 of 36 checks passed
@bdraco bdraco deleted the empty_prepare_hooks branch September 18, 2024 13:23
@patchback Patchback
Copy link
Contributor

patchback bot commented Sep 18, 2024 •
edited
Loading

Backport to 3.10: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.10/d3c3c6a7fd752450554ccbbcf875cc17740ceaa2/pr-9173

Backported as #9188

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Sep 18, 2024
@bdraco @patchback
Avoid calling response prepare hook if its empty (#9173)
c1fde78 
(cherry picked from commit d3c3c6a)
@patchback patchback bot mentioned this pull request Sep 18, 2024
Merged
@patchback Patchback
Copy link
Contributor

patchback bot commented Sep 18, 2024 •
edited
Loading

Backport to 3.11: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.11/d3c3c6a7fd752450554ccbbcf875cc17740ceaa2/pr-9173

Backported as #9189

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Sep 18, 2024
@bdraco @patchback
Avoid calling response prepare hook if its empty (#9173)
65225c6 
(cherry picked from commit d3c3c6a)
@patchback patchback bot mentioned this pull request Sep 18, 2024
Merged
bdraco added a commit that referenced this pull request Sep 18, 2024
@patchback @bdraco
[PR #9173/d3c3c6a7 backport][3.10] Avoid calling response prepare hoo…
df0f28b 
…k if its empty (#9188)

Co-authored-by: J. Nick Koston <[email protected]>
bdraco added a commit that referenced this pull request Sep 18, 2024
@patchback @bdraco
[PR #9173/d3c3c6a7 backport][3.11] Avoid calling response prepare hoo…
45dd34c 
…k if its empty (#9189)

Co-authored-by: J. Nick Koston <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@webknjaz webknjaz webknjaz approved these changes

@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

Assignees
No one assigned
Labels
backport-3.10 Trigger automatic backporting to the 3.10 release branch by Patchback robot backport-3.11 Trigger automatic backporting to the 3.11 release branch by Patchback robot bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bdraco @webknjaz