Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test typing round 6 #9226

Merged
merged 10 commits into from
Sep 25, 2024
Merged

Test typing round 6 #9226

merged 10 commits into from
Sep 25, 2024

Conversation

Dreamsorcerer
Copy link
Member

Will review and complete later tonight.

@Dreamsorcerer Dreamsorcerer added bot:chronographer:skip This PR does not need to include a change note backport:skip Skip backport bot labels Sep 22, 2024
@Dreamsorcerer Dreamsorcerer marked this pull request as draft September 22, 2024 15:44
tests/test_web_runner.py Dismissed Show dismissed Hide dismissed
tests/test_web_websocket.py Fixed Show fixed Hide fixed
tests/test_web_websocket.py Dismissed Show dismissed Hide dismissed
tests/test_web_websocket.py Fixed Show fixed Hide fixed
tests/test_web_websocket.py Fixed Show fixed Hide fixed
tests/test_web_websocket.py Fixed Show fixed Hide fixed
Copy link

codecov bot commented Sep 22, 2024

Codecov Report

Attention: Patch coverage is 99.72145% with 1 line in your changes missing coverage. Please review.

Project coverage is 98.55%. Comparing base (de997af) to head (9162625).
Report is 1 commits behind head on master.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
tests/test_web_sendfile_functional.py 98.11% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9226      +/-   ##
==========================================
+ Coverage   98.41%   98.55%   +0.13%     
==========================================
  Files         107      107              
  Lines       34828    34855      +27     
  Branches     4132     4128       -4     
==========================================
+ Hits        34277    34352      +75     
+ Misses        380      335      -45     
+ Partials      171      168       -3     
Flag Coverage Δ
CI-GHA 98.44% <99.72%> (+0.13%) ⬆️
OS-Linux 98.10% <99.72%> (+0.13%) ⬆️
OS-Windows 96.51% <99.71%> (+0.14%) ⬆️
OS-macOS 97.79% <99.72%> (+0.14%) ⬆️
Py-3.10.11 97.77% <99.72%> (+0.14%) ⬆️
Py-3.10.15 97.70% <99.72%> (+0.13%) ⬆️
Py-3.11.10 97.67% <99.72%> (+0.13%) ⬆️
Py-3.11.9 97.73% <99.72%> (+0.14%) ⬆️
Py-3.12.6 98.16% <99.72%> (+0.13%) ⬆️
Py-3.13.0-rc.2 98.14% <99.72%> (+0.13%) ⬆️
Py-3.9.13 97.67% <99.72%> (+0.14%) ⬆️
Py-3.9.20 97.60% <99.72%> (+0.13%) ⬆️
Py-pypy7.3.16 97.22% <99.72%> (+0.14%) ⬆️
VM-macos 97.79% <99.72%> (+0.14%) ⬆️
VM-ubuntu 98.10% <99.72%> (+0.13%) ⬆️
VM-windows 96.51% <99.71%> (+0.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Dreamsorcerer Dreamsorcerer marked this pull request as ready for review September 25, 2024 16:38
tests/test_web_sendfile_functional.py Fixed Show fixed Hide fixed
tests/test_web_sendfile_functional.py Dismissed Show dismissed Hide dismissed
@Dreamsorcerer Dreamsorcerer merged commit 56aa261 into master Sep 25, 2024
39 of 40 checks passed
@Dreamsorcerer Dreamsorcerer deleted the test-typing6 branch September 25, 2024 18:06
Dreamsorcerer added a commit that referenced this pull request Sep 25, 2024
Dreamsorcerer added a commit that referenced this pull request Sep 25, 2024
patchback bot pushed a commit that referenced this pull request Sep 26, 2024
(cherry picked from commit 552dea5)
Dreamsorcerer added a commit that referenced this pull request Sep 26, 2024
**This is a backport of PR #9294 as merged into 3.11
(552dea5).**

Co-authored-by: Sam Bull <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip Skip backport bot bot:chronographer:skip This PR does not need to include a change note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant