Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #9455/dfaafac0 backport][3.10] Fix AsyncResolver query fallback swallowing the error message #9456

Conversation

patchback[bot]
Copy link
Contributor

@patchback patchback bot commented Oct 10, 2024

This is a backport of PR #9455 as merged into 3.11 (dfaafac).

Same change as #9451 but for the query fallback code for older versions of aiodns

Copy link

codecov bot commented Oct 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.81%. Comparing base (ba9b33e) to head (7b7decf).
Report is 1 commits behind head on 3.10.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             3.10    #9456      +/-   ##
==========================================
+ Coverage   97.79%   97.81%   +0.01%     
==========================================
  Files         108      108              
  Lines       34968    34986      +18     
  Branches     4185     4191       +6     
==========================================
+ Hits        34198    34221      +23     
+ Misses        573      569       -4     
+ Partials      197      196       -1     
Flag Coverage Δ
CI-GHA 97.70% <100.00%> (+0.01%) ⬆️
OS-Linux 97.38% <100.00%> (+0.01%) ⬆️
OS-Windows 94.92% <20.00%> (-0.04%) ⬇️
OS-macOS 97.08% <100.00%> (+0.01%) ⬆️
Py-3.10.11 96.94% <100.00%> (+0.01%) ⬆️
Py-3.10.15 96.87% <100.00%> (+0.01%) ⬆️
Py-3.11.10 96.96% <100.00%> (+0.01%) ⬆️
Py-3.11.9 97.05% <100.00%> (+0.03%) ⬆️
Py-3.12.7 97.41% <100.00%> (+0.01%) ⬆️
Py-3.13.0 97.40% <100.00%> (+0.01%) ⬆️
Py-3.8.10 94.30% <20.00%> (-0.04%) ⬇️
Py-3.8.18 96.67% <100.00%> (+0.01%) ⬆️
Py-3.9.13 96.85% <100.00%> (+0.01%) ⬆️
Py-3.9.20 96.79% <100.00%> (+0.01%) ⬆️
Py-pypy7.3.16 96.39% <100.00%> (+0.01%) ⬆️
VM-macos 97.08% <100.00%> (+0.01%) ⬆️
VM-ubuntu 97.38% <100.00%> (+0.01%) ⬆️
VM-windows 94.92% <20.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco bdraco changed the title [PR #9455/dfaafac0 backport][3.10] [3.11] Fix AsyncResolver query fallback swallowing the error message [PR #9455/dfaafac0 backport][3.10] Fix AsyncResolver query fallback swallowing the error message Oct 10, 2024
@bdraco bdraco merged commit ee87a04 into 3.10 Oct 10, 2024
37 of 38 checks passed
@bdraco bdraco deleted the patchback/backports/3.10/dfaafac078d3f5ee5902933709f7264e9b1ffd70/pr-9455 branch October 10, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant