-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Combine duplicate logic in Response.write_eof
#9772
Conversation
CodSpeed Performance ReportMerging #9772 will not alter performanceComparing Summary
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #9772 +/- ##
==========================================
- Coverage 98.67% 98.67% -0.01%
==========================================
Files 117 117
Lines 35958 35956 -2
Branches 4276 4275 -1
==========================================
- Hits 35482 35480 -2
Misses 320 320
Partials 156 156
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Backport to 3.10: 💚 backport PR created✅ Backport PR branch: Backported as #9773 🤖 @patchback |
(cherry picked from commit eaa1086)
Backport to 3.11: 💚 backport PR created✅ Backport PR branch: Backported as #9774 🤖 @patchback |
(cherry picked from commit eaa1086)
…se.write_eof` (#9774) Co-authored-by: J. Nick Koston <[email protected]>
…se.write_eof` (#9773) Co-authored-by: J. Nick Koston <[email protected]>
There were two branches that called
await super().write_eof()
that could be combined