Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #9771/e80d5854 backport][3.10] Small cleanups to enabling compression in web_response #9776

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Nov 10, 2024

(cherry picked from commit e80d585)

@bdraco bdraco changed the title Small cleanups to enabling compression in web_response (#9771) [PR #9771/e80d5854 backport][3.10] Small cleanups to enabling compression in web_response Nov 10, 2024
@bdraco bdraco added the bot:chronographer:skip This PR does not need to include a change note label Nov 10, 2024
Copy link

codspeed-hq bot commented Nov 10, 2024

CodSpeed Performance Report

Merging #9776 will not alter performance

Comparing patchback/backports/3.10/e80d58544812bdc537a256d3776920481daf0578/pr-9771 (41f1853) with 3.10 (9d9d76b)

Summary

✅ 15 untouched benchmarks

Copy link

codecov bot commented Nov 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.90%. Comparing base (9d9d76b) to head (41f1853).
Report is 2 commits behind head on 3.10.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             3.10    #9776   +/-   ##
=======================================
  Coverage   97.89%   97.90%           
=======================================
  Files         112      112           
  Lines       35668    35680   +12     
  Branches     4298     4299    +1     
=======================================
+ Hits        34918    34932   +14     
+ Misses        557      556    -1     
+ Partials      193      192    -1     
Flag Coverage Δ
CI-GHA 97.79% <100.00%> (+<0.01%) ⬆️
OS-Linux 97.48% <100.00%> (+<0.01%) ⬆️
OS-Windows 95.08% <100.00%> (+<0.01%) ⬆️
OS-macOS 97.19% <100.00%> (+<0.01%) ⬆️
Py-3.10.11 97.04% <100.00%> (+<0.01%) ⬆️
Py-3.10.15 97.02% <100.00%> (+0.04%) ⬆️
Py-3.11.10 97.06% <100.00%> (-0.05%) ⬇️
Py-3.11.9 97.13% <100.00%> (+0.01%) ⬆️
Py-3.12.7 97.56% <100.00%> (-0.01%) ⬇️
Py-3.13.0 97.54% <100.00%> (-0.01%) ⬇️
Py-3.8.10 94.47% <100.00%> (+<0.01%) ⬆️
Py-3.8.18 96.83% <100.00%> (+<0.01%) ⬆️
Py-3.9.13 96.96% <100.00%> (+<0.01%) ⬆️
Py-3.9.20 96.94% <100.00%> (-0.01%) ⬇️
Py-pypy7.3.16 96.51% <100.00%> (+<0.01%) ⬆️
VM-macos 97.19% <100.00%> (+<0.01%) ⬆️
VM-ubuntu 97.48% <100.00%> (+<0.01%) ⬆️
VM-windows 95.08% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco bdraco marked this pull request as ready for review November 10, 2024 19:58
@bdraco bdraco enabled auto-merge (squash) November 10, 2024 19:58
@bdraco bdraco merged commit 5a9c2fb into 3.10 Nov 10, 2024
39 of 40 checks passed
@bdraco bdraco deleted the patchback/backports/3.10/e80d58544812bdc537a256d3776920481daf0578/pr-9771 branch November 10, 2024 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:skip This PR does not need to include a change note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant