Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #9780/eac8fb84 backport][3.11] Replace get_event_loop with get_running_loop in the compressor #9789

Conversation

patchback[bot]
Copy link
Contributor

@patchback patchback bot commented Nov 10, 2024

This is a backport of PR #9780 as merged into master (eac8fb8).

What do these changes do?

Replace get_event_loop with get_running_loop in the compressor. This should never be called without a running event loop as its in an async function.

asyncio.get_event_loop:

Deprecated since version 3.12: Deprecation warning is emitted if there is no current event loop. In some future Python release this will become an error

There was no need to call the sync wrapper function since we are already inside the object and can call the compressor/decompressor directly.

Adds missing test coverage

Are there changes in behavior for the user?

no

Is it a substantial burden for the maintainers to support this?

no

@bdraco bdraco enabled auto-merge (squash) November 10, 2024 22:09
Copy link

codspeed-hq bot commented Nov 10, 2024

CodSpeed Performance Report

Merging #9789 will not alter performance

Comparing patchback/backports/3.11/eac8fb84417fd55128e2263f60ef3efa6ba51abd/pr-9780 (7241f4f) with 3.11 (e499d55)

Summary

✅ 15 untouched benchmarks

Copy link

codecov bot commented Nov 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.96%. Comparing base (e499d55) to head (7241f4f).
Report is 2 commits behind head on 3.11.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             3.11    #9789      +/-   ##
==========================================
+ Coverage   97.49%   97.96%   +0.47%     
==========================================
  Files         117      118       +1     
  Lines       36029    36049      +20     
  Branches     4321     4331      +10     
==========================================
+ Hits        35126    35317     +191     
+ Misses        690      546     -144     
+ Partials      213      186      -27     
Flag Coverage Δ
CI-GHA 97.85% <100.00%> (+0.43%) ⬆️
OS-Linux 97.55% <100.00%> (+0.20%) ⬆️
OS-Windows 94.50% <100.00%> (?)
OS-macOS 96.77% <100.00%> (+0.10%) ⬆️
Py-3.10.11 96.62% <100.00%> (+0.30%) ⬆️
Py-3.10.15 97.05% <100.00%> (+<0.01%) ⬆️
Py-3.11.10 97.17% <100.00%> (+0.05%) ⬆️
Py-3.11.9 96.69% <100.00%> (+0.29%) ⬆️
Py-3.12.7 97.62% <100.00%> (+1.07%) ⬆️
Py-3.13.0 97.61% <100.00%> (+1.06%) ⬆️
Py-3.9.13 96.55% <100.00%> (?)
Py-3.9.20 96.98% <100.00%> (?)
Py-pypy7.3.16 96.59% <100.00%> (?)
VM-macos 96.77% <100.00%> (+0.10%) ⬆️
VM-ubuntu 97.55% <100.00%> (+0.20%) ⬆️
VM-windows 94.50% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco bdraco merged commit 5cf39d9 into 3.11 Nov 10, 2024
34 of 35 checks passed
@bdraco bdraco deleted the patchback/backports/3.11/eac8fb84417fd55128e2263f60ef3efa6ba51abd/pr-9780 branch November 10, 2024 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant