Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated BrokerMetadata#nodeId type from int to int | str. #1051

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Updated BrokerMetadata#nodeId type from int to int | str. #1051

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions aiokafka/structs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
from dataclasses import dataclass
from typing import Generic, List, NamedTuple, Optional, Sequence, Tuple, TypeVar
from typing import Generic, List, NamedTuple, Optional, Sequence, Tuple, TypeVar, Union

from aiokafka.errors import KafkaError

Expand All @@ -26,7 +26,7 @@ class TopicPartition(NamedTuple):
class BrokerMetadata(NamedTuple):
"""A Kafka broker metadata used by admin tools"""

nodeId: int
nodeId: Union[int, str]
"The Kafka broker id"

host: str
Expand Down