Unable to set a connect_timeout

[terrisgit]

aiomysql==0.0.12

Reading through the code, kwargs passed to create_pool() are captured and passed along. The code looks correct but setting connect_timeout to 1 versus 1000 makes no difference. The timeout is always two minutes and a few seconds. Something like:

pool = await aiomysql.create_pool(user=user, db=database, host=host,
      password=password, port=port, connect_timeout=1 )

[jettify]

That is a good catch, we need to wrap open_connection into asyncio.wait_for and add pass connect_timeout there

aiomysql/aiomysql/connection.py

Lines 456 to 466 in d77a97d

	if self._unix_socket and self._host in ('localhost', '127.0.0.1'):
	self._reader, self._writer = yield from \
	asyncio.open_unix_connection(self._unix_socket,
	loop=self._loop)
	self.host_info = "Localhost via UNIX socket: " + \
	self._unix_socket
	else:
	self._reader, self._writer = yield from \
	asyncio.open_connection(self._host, self._port,
	loop=self._loop)
	self._set_keep_alive()

[jettify]

would you like to create PR?

[mpavelka]

+1, is there a progress?

[terricain]

Once we've fixed SSL (hopefully in the next few days) I'll PR this, should be simple.

[VeridianDynamics]

Has this been solved and the issue is just forgotten, or has there been some unforeseen roadblock? Thanks.

[maciej-trebacz]

@terrycain did you get to implement this PR in the end? Thanks.

[terricain]

I didn't, I completely forgot 😄, I'll have a crack at this on the weekend unless someone else wishes to do so.