Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an rsa extra require? #557

Closed
JulienPalard opened this issue Jan 15, 2021 · 2 comments · Fixed by #733
Closed

Add an rsa extra require? #557

JulienPalard opened this issue Jan 15, 2021 · 2 comments · Fixed by #733
Labels
enhancement
Milestone
0.1

Comments

@JulienPalard
Copy link

What about adding an aiomysql[rsa] extra require, depending on PyMySQL[rsa], to pull cryptography?

It would have an advantage over manually installing cryptography: to pull the right version. Currently PyMySQL does not requires any specific version of cryptography, but could in the future.
@Nothing4You
Copy link
Collaborator

if that's added ed25519 should probably also be added

Nothing4You added a commit that referenced this issue Feb 17, 2022
@Nothing4You
Add rsa extras_require depending on PyMySQL[rsa]
ccad9c4 
fixes #557
@Nothing4You Nothing4You mentioned this issue Feb 17, 2022
Merged
4 tasks
Nothing4You added a commit that referenced this issue Feb 18, 2022
@Nothing4You
Add rsa extras_require depending on PyMySQL[rsa] (#733)
bf8b11e 
fixes #557
@Nothing4You
Copy link
Collaborator

ed25519 should be added when support for ed25519 is implemented, RSA will be available in the next release.

@Nothing4You Nothing4You added this to the 0.1 milestone Feb 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
0.1
Development

Successfully merging a pull request may close this issue.

Add rsa extras_require depending on PyMySQL[rsa] aio-libs/aiomysql
2 participants
@JulienPalard @Nothing4You