Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade cython to 3.0.0b1, add 3.12 to test matrix #436

Merged
merged 1 commit into from
Mar 18, 2023
Merged

Conversation

mjpieters
Copy link
Collaborator

This release is compatible with Python 3.12a05 (and up). While here, extend
the tox configuration to also cover 3.11 and 3.12, and have GitHub test against
3.12.

Related issue number

Fixes #433

.github/workflows/ci.yml Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Mar 1, 2023

Codecov Report

Merging #436 (79f7b8f) into master (ec4d55c) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #436   +/-   ##
=======================================
  Coverage   98.36%   98.36%           
=======================================
  Files           1        1           
  Lines          61       61           
  Branches        9        9           
=======================================
  Hits           60       60           
  Misses          1        1           
Flag Coverage Δ
unit 96.72% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mjpieters
Copy link
Collaborator Author

@asvetlov, @webknjaz how do we feel about a dependency on cython 3.0.0b1, a prerelease version, here?

@webknjaz
Copy link
Member

webknjaz commented Mar 1, 2023

In CI, it's probably fine. Through, maybe just for 3.12 for now?

@Dreamsorcerer
Copy link
Member

Maybe also an experimental flag?
aio-libs/aiohttp@ced2c50

@mjpieters
Copy link
Collaborator Author

In CI, it's probably fine. Through, maybe just for 3.12 for now?

Not sure what that'd achieve though. We can't release a 3.12-compatible tarball without Cython 3.0.0b1 at the moment (it looks like the changes required for Cython 0.29.x are extensive).

@webknjaz
Copy link
Member

Alright... Fair enough.

Copy link
Member

@webknjaz webknjaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mjpieters feel free to merge upon resolving the conflicts.

@webknjaz webknjaz enabled auto-merge (squash) March 17, 2023 15:30
This release is compatible with Python 3.12a05 (and up).  While here, extend
the tox configuration to also cover 3.11 and 3.12, and have GitHub test against
3.12.
@patrick91
Copy link

@mjpieters sorry for the ping, would be possible to get a new release with this PR?

this is blocking a PR where I'm adding 3.12 to the testing pipeline 😊

@webknjaz
Copy link
Member

@patrick91 I'll take a look in a minute.

@webknjaz
Copy link
Member

I'll need to make a few metadata adjustments, like removing/replacing dead links, etc. Then, I'll trigger the release pipeline.

@webknjaz
Copy link
Member

https://pypi.org/project/frozenlist/1.4.0/ / https://github.com/aio-libs/frozenlist/releases/tag/v1.4.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't install frozenlist on Python 3.12
5 participants