Reorganize to docker action #17
Conversation
Codecov Report
@@ Coverage Diff @@
## master #17 +/- ##
==========================================
+ Coverage 70.17% 73.80% +3.63%
==========================================
Files 1 1
Lines 57 126 +69
Branches 10 27 +17
==========================================
+ Hits 40 93 +53
- Misses 16 27 +11
- Partials 1 6 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
| INPUT_FIX_ISSUE_REGEX: ${{ inputs.fix_issue_regex }} | ||
| INPUT_FIX_ISSUE_REPL: ${{ inputs.fix_issue_repl }} | ||
| using: docker | ||
| image: Dockerfile |
There was a problem hiding this comment.
Note that with this approach, every job using the action will build the image. I've seen some actions optimizing this by publishing the built images to registries and pointing this there instead. Notably this one: https://github.com/fedora-python/tox-github-action/blob/9f7d1ff/action.yaml#L14.
There was a problem hiding this comment.
Interesting.
Does Github cache the built docker image?
An explicit image registry complicates the release process. Not drastically but still extra steps.
The project was super-lightweight initially. Now it grows :(
There was a problem hiding this comment.
Does Github cache the built docker image?
It does not. This is why I emphasized that this happens in every job.
An explicit image registry complicates the release process. [...] The project was super-lightweight initially. Now it grows :(
Yep, this is why I mentioned it. I still haven't built good automation for this but I've been wanting to use this approach for some of my actions like PyPI upload for a while now.
| @@ -71,13 +70,26 @@ jobs: | |||
| uses: py-actions/py-dependency-install@v2 | |||
| with: | |||
| path: requirements.txt | |||
| - name: Install Itself | |||
There was a problem hiding this comment.
FYI this is grammatically incorrect — saying that pip installs itself means that pip installs pip. Maybe it would be acceptable to say "Self-install" but even then, it would mean that the project installs itself (as in aiohttp installs aiohttp).
A better way could be to say "Install the tested project to the current environment in the editable mode"
There was a problem hiding this comment.
Feel free to fix please
No description provided.