[JIT] Add TorchScript Compatibility for ANIModel and Ensemble #307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zasdfgbnm
suggested changes
Sep 13, 2019
There was a problem hiding this comment.
I think the problem comes from the definition of Sequential: When JIT is trying to compile the code for Sequential, it assumes that the input of Sequential.forward is a Tensor. I think we should eventually remove Sequential, but write our own class with correct type annotation of forward instead. But for now, this PR, why not just
self.model_iterator = torch.jit.script(self.model_iterator)
self.ensemble = torch.nn.Sequential(self.aev_computer, self.model_iterator)Instead of
self.ensemble = torch.nn.Sequential(self.aev_computer, self.model_iterator)
self.ensemble = torch.jit.script(self.ensemble)and leave the problem of Sequencial to fix it in later PR?
|
Problem with type annotation shows up every where |
farhadrgh
changed the title
|
@farhadrgh Should be working |
zasdfgbnm
changed the title
7 tasks
zasdfgbnm
changed the title
zasdfgbnm
approved these changes
Oct 9, 2019
There was a problem hiding this comment.
@farhadrgh I am giving out approval. If it also looks good to you, then please merge.
|
Looks good, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes one of the items in #305