Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move unittest check to GitHub Actions #317

Merged
merged 11 commits into from
Sep 23, 2019
Merged

Move unittest check to GitHub Actions #317

merged 11 commits into from
Sep 23, 2019

Conversation

zasdfgbnm
Copy link
Contributor

@zasdfgbnm zasdfgbnm commented Sep 23, 2019

Tests are parallelized, which significantly reduces the latency for waiting these tests. Azure pipelines are now only used to deploy for now.

@zasdfgbnm
Copy link
Contributor Author

Hi @farhadrgh, I moved almost all CI checks to GitHub Actions because it is easier to manage. And more importantly, the unit test is now parallelized and should be faster to run. Due to this change, I have to temporarily disable most branch protections. So for this week only, all admins could merge things without passing these checks. So be careful.

@zasdfgbnm
Copy link
Contributor Author

Please review this, make sure all tests are covered at matrix.test-filenames and if correct, merge. (I merged all other changes without reviewing, because they are more trivial, less important, and reviewing is not convenient in changing the whole CI structure)

@zasdfgbnm
Copy link
Contributor Author

Also in the future, if new test files are added, remember to update the workflow

@zasdfgbnm
Copy link
Contributor Author

Also, after this gets merged, we should start splitting larger tests into different files, so that we can run them in parallel to reduce the latency.

This was referenced Sep 23, 2019
Copy link
Member

@farhadrgh farhadrgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@farhadrgh farhadrgh merged commit c67ec7d into master Sep 23, 2019
@farhadrgh farhadrgh deleted the zasdfgbnm-patch-1 branch September 23, 2019 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants